Add module include support for mixin method resolution#57
Merged
Conversation
Previously, `include` was treated as an implicit self method call, causing false type errors when calling methods defined in included modules (e.g., `User.new.greet` where `greet` is from `Greetable`). This adds mixin tracking to GlobalEnv and extends the MRO fallback chain to search included modules between the class itself and Object, matching Ruby's method resolution order semantics. Supports: single/multiple includes, qualified module names (A::B), simultaneous include (include A, B), and correct MRO priority. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includedetection indispatch.rsto recognize module mixin declarations (single, multiple, qualified names)GlobalEnvviamodule_inclusions: HashMap<String, Vec<String>>MethodRegistry::fallback_chainto search included modules between the class and Object, following Ruby's MRO (last included module has highest priority)Why
include Greetablewas previously treated as an unknown implicit self method call, producing falseTypeErroron methods defined in included modules. This is a fundamental Ruby pattern that must be supported for practical type checking.Test plan
MethodRegistryresolve with inclusions, MRO order, class priority over include, include before Objectcd core && cargo test --lib— all tests passbundle exec rake test— all tests pass🤖 Generated with Claude Code